node object in FindObject call is not for limiting search scope, but for access control (it will only find objects where this node set as trusted if trusted nodes check is on). If you have trusted nodes check off, you can pass null as node parameter.

Best regards,
Victor

If I use FindInterfaceByName, I would have to loop through all interfaces on the node for each individual interface I want to instance (as per your code). If I have a switch stack of 96 ports or more, that would cost some resources every time an instance discovery is running. I was hoping that if I can use FindObject instead and provide the $node as per documentation, i.e. FindObject($1,$node), that should not be a global search and avoid the loops?
Guess I'll wait for 2.0.5 and see if I can get it to work with that. Otherwise I'll be looping.

Cheers

yes, it is bug in FindObject (fixed in 2.0.5). Anyway, it may not be a good idea to use FindObject - because it finds objects globally, while you need interfaces from that specific node. You can add the following function to your script to get interface by name:

sub FindInterfaceByName(node, ifName)
{
	foreach(i : GetNodeInterfaces(node))
	{
	   if (i->name == ifName)
	      return i;
	}
	return null;
}

and use it like this:

iface = FindInterfaceByName($node, "Se1/0");

Best regards,
Victor

If I use FindObject, for all I can tell I should be getting an interface object.
After going through some older forum posts I thought I'd test that as follows:

i = FindObject($1,$node);
trace (0,i->name);
trace (0,classof(i));

The logs then give me the interface name and "NetObj" in the logs.
That also explains why none of the interface attributes (short of the NetObj ones) were accessible - I got the wrong object type back. Based on the documentation I would have thought this should be "Interface"?

i = GetInterfaceObject($node, $1);
if ((i != null) && (i->expectedState == 0))
{
	return %(true, $1, i->description);
}
return false;

Not sure how well this would work inside of an instance filter script.
Instance Discovery will loop through the list of all interfaces and return the names, one by one. It's inside that loop that the instance filter script runs (for all I understand).
I guess I could loop through all node interfaces for each interface on the node discovered by Instance Discovery, then compare names and on a match check the expectedState. Seems a bit inefficient though. If I could directly retrieve the correct interface object from within the instance filter script, it would be a fairly quick check.

From what I read about FindObject, that should have worked using the interface name provided by Instance Discovery.  But I could not use any of the object's properties afterwards.  ???
I might give it another go later today and provide the code I used. Maybe I've had some typo or logic error in there - wouldn't be the first time.  :-[

this is a part of my ConfigPoll hook, which is looking for expectedState of an interface. Maybe this will help you.

interfaces = GetNodeInterfaces($node);
foreach(i : interfaces) {
	if(i->expectedState == 0) {	// 0 = UP, 1 = DOWN, 2 = IGNORE
		...
	}
	else {
		...
	}
}